refactors to use more features from rest_framework

this commit adds the use of Response and @api_view to the snippet views
This commit is contained in:
Emanuel Rodriguez 2022-08-07 20:39:42 -07:00
parent 1e8647d478
commit 58a7cbb133
1 changed files with 14 additions and 13 deletions

View File

@ -1,46 +1,47 @@
from django.http import HttpResponse, JsonResponse from rest_framework import status
from django.views.decorators.csrf import csrf_exempt from rest_framework.decorators import api_view
from rest_framework.parsers import JSONParser from rest_framework.response import Response
from snippets.models import Snippet from snippets.models import Snippet
from snippets.serializers import SnippetSerializer from snippets.serializers import SnippetSerializer
@csrf_exempt @api_view(["GET", "POST"])
def snippet_list(request): def snippet_list(request):
if request.method == "GET": if request.method == "GET":
snippets = Snippet.objects.all() snippets = Snippet.objects.all()
serializer = SnippetSerializer(snippets, many=True) serializer = SnippetSerializer(snippets, many=True)
return JsonResponse(data=serializer.data, safe=False) return Response(serializer.data)
elif request.method == "POST": elif request.method == "POST":
data = JSONParser().parse(request) data = JSONParser().parse(request)
serializer = SnippetSerializer(data=data) serializer = SnippetSerializer(data=data)
if serializer.is_valid(): if serializer.is_valid():
serializer.save() serializer.save()
return JsonResponse(serializer.data, status=201) return Response(serializer.data, status=status.HTTP_201_CREATED)
return JsonResponse(serializer.errors, status=400) return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
@csrf_exempt @api_view(["GET", "PUT", "DELETE"])
def snippet_detail(request, pk): def snippet_detail(request, pk):
try: try:
snippet = Snippet.objects.get(pk=pk) snippet = Snippet.objects.get(pk=pk)
except Snippet.DoesNotExist: except Snippet.DoesNotExist:
return HttpResponse(status=404) return Response(status=status.HTTP_404_NOT_FOUND)
if request.method == "GET": if request.method == "GET":
serializer = SnippetSerializer(snippet) serializer = SnippetSerializer(snippet)
return JsonResponse(data=serializer.data) return Response(serializer.data)
elif request.method == "PUT": elif request.method == "PUT":
data = JSONParser().parse(request) data = JSONParser().parse(request)
serializer = SnippetSerializer(snippet, data=data) serializer = SnippetSerializer(snippet, data=data)
if serializer.is_valid(): if serializer.is_valid():
serializer.save() serializer.save()
return JsonResponse(serializer.data) return Response(serializer.data)
return JsonResponse(serializer.errors, status=400) return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
elif request.method == "DELETE": elif request.method == "DELETE":
snippet.delete() snippet.delete()
return HttpResponse(status=204) return Response(status=status.HTTP_204_NO_CONTENT)